test: Skip some spanner tests to restore Google Cloud Build health#8869
Open
danieljbruce wants to merge 6 commits into
Open
test: Skip some spanner tests to restore Google Cloud Build health#8869danieljbruce wants to merge 6 commits into
danieljbruce wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request skips several Spanner system tests in handwritten/spanner/system-test/spanner.ts due to Kokoro to GCB migration errors. The reviewer recommends adding a TODO comment or referencing a tracking issue to ensure these skipped tests are eventually re-enabled once the migration issues are resolved.
…pis/google-cloud-node into skip-extra-spanner-tests
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
danieljbruce
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #8864 where we simply skip a few tests to restore the GCB CI check back to a passing state.
Impact
Restores the health of the GCB check